Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Jira: fixing schemas accordinately to response. #4947

Merged
merged 12 commits into from
Jul 28, 2021
Merged

Source Jira: fixing schemas accordinately to response. #4947

merged 12 commits into from
Jul 28, 2021

Conversation

vovavovavovavova
Copy link
Contributor

@vovavovavovavova vovavovavovavova commented Jul 23, 2021 •
edited by keu
Loading

What

Closes #4341 and #4950

How

By fixing all the schemas that are currently using in the Jira connector. Current version can produce
KeyError: "'json_schema'.'properties' are not defined for stream project_components" Errors. Dev version suggested in this pr does not have that, at least in my case.

Recommended reading order

  1. x.java
  2. y.python

@github-actions github-actions bot added the area/connectors Connector related issues label Jul 23, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Jul 23, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-cart

🕑 connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1059635676
❌ connectors/source-cart https://github.com/airbytehq/airbyte/actions/runs/1059635676

@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Jul 23, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1059637114
❌ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1059637114

@vovavovavovavova vovavovavovavova changed the title Valdemar/#4341 jira schemas bug Source Jira: fixing schemas accordinately to response. Jul 27, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Jul 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1070646433
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1070646433

@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Jul 27, 2021 •
edited by github-actions bot
Loading

/test connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1070721874
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1070721874

keu
keu reviewed Jul 28, 2021
View reviewed changes
airbyte-integrations/connectors/source-jira/integration_tests/inc_configured_catalog.json Outdated
"stream": {
"name": "issues",
"json_schema": {},
"supported_sync_modes",: ["incremental"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

keu
keu reviewed Jul 28, 2021
View reviewed changes
airbyte-integrations/connectors/source-jira/source_jira/schemas/application_roles.json
"type": "array",
"description": "The groups associated with the application role.",
"items": { "type": "string" }
"items": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied but somewhy it does not available in commit diff (available in global diff)

keu
keu reviewed Jul 28, 2021
View reviewed changes
Copy link
Contributor

@keu keu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jul 28, 2021
@vovavovavovavova
Copy link
Contributor Author

vovavovavovavova commented Jul 28, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-jira

🕑 connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1075469689
✅ connectors/source-jira https://github.com/airbytehq/airbyte/actions/runs/1075469689

@vovavovavovavova vovavovavovavova merged commit 625a88c into master Jul 28, 2021
@vovavovavovavova vovavovavovavova deleted the valdemar/#4341_jira_schemas_bug branch July 28, 2021 16:35
@marcosmarxm marcosmarxm mentioned this pull request Aug 6, 2021
Closed
@vovavovavovavova vovavovavovavova mentioned this pull request Aug 31, 2021
Merged
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keu keu keu approved these changes

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@gaart gaart Awaiting requested review from gaart

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jira Connector declares "created" cursor field but does not include it in its catalog
2 participants
@vovavovavovavova @keu